Open
Conversation
|
@RachelYang02 + @jag-123 - nice job on this. The writeup was thorough and thoughtful - good job acknowledging the different features that could go into a future iteration of the game. Overall, good documentation throughout with docstrings and in-line comments (though it seems a bit lighter near the end of the file). I'll go through the code after this and add some comments as well. Good job! |
main.py
Outdated
| @@ -0,0 +1,515 @@ | |||
| """player for game""" | |||
There was a problem hiding this comment.
Don't forget to add a header/docstring with a short description of what the code contains/does.
|
In the future, should you make another game, dividing the MVC into separate files will help improve readability, but nicely done overall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment for Interactive Programming Mini Project 4
This change is