apurva and louise submitting interactiveprogramming#13
apurva and louise submitting interactiveprogramming#13nielseneli wants to merge 17 commits intosd16spring:masterfrom
Conversation
… for the mid-project check-in
…led out yet though
…opefully will help us with general implementation and making buttons.
… using pandas, caught up to where we were before without pandas and figured out color settings.
… patience (or memory) to write individual commit messages for
|
@nielsenlouise + @apurvaraman - nice job on this and working with Bokeh - it's tough for sure. In terms of your writeup, it was well-organized, clear, and thoughtful. Good point about being more cautious when scoping out a project that uses a library you're unfamiliar with. Also, good note about using pandas as recommended by Bokeh, though I'm sure if searching through dictionaries would've been that big of a bottleneck since you can do direct lookups in dictionaries and not necessarily have to "iterate" through the dictionary (though you're right - you would have to go through all the separate category dictionaries). I'll add comments to your code after this. |
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| thing = View() |
There was a problem hiding this comment.
Overall - code looks good! It was nicely designed and well documented. For the most part, variable names were sensibly chosen.
You should include a .gitignore file in your repository to prevent *.pyc files from being pushed. For more info on .gitignore, see https://git-scm.com/docs/gitignore
2 participants
This change is