Project 4 Pong Game Bill Du and Harper Owen

[charliehowen]

No description provided.

[YuzhongHuang]

Review status: 0 of 3 files reviewed at latest revision, 6 unresolved discussions.

---

a discussion (no related file):
Interesting project. Code looks good overall. Deleting unused code before turn in will the make the code looks more clean and professional. There is some places where you use doc string to replace inline comments. I understand that doc strings look prettier than inline comments, but they are not interchangeable. Also try to use git more to keep the project more organized and under version control.

Nicely done overall. Looking forward to your future working!

---

pong_game.py, line 1 [r2] (raw file):
A brief heading describing what does the code do overall would be helpful for others to understand

---

pong_game.py, line 36 [r2] (raw file):
deletes unused code for final turn in next time.

---

pong_game.py, line 122 [r2] (raw file):
It might be more intuitive for collision() to just check for collision and returns a boolean and leave the actual bounce work for bounce()

---

pong_game.py, line 235 [r2] (raw file):
Inline comments don't replace docstrings

---

pong_game.py, line 293 [r2] (raw file):
Comments on external lib imported will be helpful for the readers to understand

---

Comments from Reviewable

[YuzhongHuang]

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

---

Comments from Reviewable