Fix: HTML nodes being silently dropped in View's Monad instance#196
Open
jkasalt wants to merge 1 commit intoseanhess:mainfrom
Open
Fix: HTML nodes being silently dropped in View's Monad instance#196jkasalt wants to merge 1 commit intoseanhess:mainfrom
jkasalt wants to merge 1 commit intoseanhess:mainfrom
Conversation
Previously `>>=` was extracting only the return value of the `Html` from the first action, discarding its nodes entierly. This caused all but the last node to be silently dropped when `>>=` was used manually or when the `ApplicativeDo` language extension introduced a `join` call (which uses `>>=` under the hood). The fix runs the first action to obtain its `Html` value, then delegates node accumulation to `Html`'s own `>>`, which correctly concatenates both node lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When using
>>=directly, or whenApplicativeDois enabled (which introduces ajoincall that goes through>>=), all but the last element in adoblock would be silently dropped from the rendered HTML.For example:
{-# LANGUAGE ApplicativeDo #-} col $ do el "One" el "Two" el "Three"or
would render only "Three".
Cause
The
>>=implementation ofViewwas extracting only the return value from the first action via(.value) <$> ea, discarding itsHtmlnodes entirely:Fix
Run the first action fully to obtain its
Htmlvalue, then delegate node accumulation toHtml's own>>, which correctly concatenates both node lists:Notes
The bug was not visible when using plain
donotation withoutApplicativeDo, because GHC desugars it to>>which is defined as(*>)and bypasses>>=entirely. The bug only manifests when>>=is called directly or throughjoin.