Add EGL 1.5 support, bug fix and refactoring.#4
Open
timothee-haudebourg wants to merge 4 commits intoseankerr:masterfrom
Open
Add EGL 1.5 support, bug fix and refactoring.#4timothee-haudebourg wants to merge 4 commits intoseankerr:masterfrom
timothee-haudebourg wants to merge 4 commits intoseankerr:masterfrom
Conversation
added 3 commits
June 15, 2019 22:20
Bug fix: the `eglGetConfigs' function was wrongly typed. `configs' should be a pointer to an array of `EGLConfig', hence have type `*mut EGLConfig' where it had the (wrong) type `EGLConfig'. Refactoring: constants and functions are now ordered by EGL version to have a more sustainable code.
Author
|
I've added a proposition to fix the |
db0aa05 to
f795adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I have added support for EGL 1.5. To do so I first had to refactor the code and order everything by EGL version so I can find my way around (sorry about that). I think it will be more sustainable this way, since it follows the structure of the original
egl.hfile it should be easier for other people to understand the structure oflib.rs.On the way i've spotted a bug: the
eglGetConfigsfunction was wrongly typed.configsshould be a pointer to an array of
EGLConfig, hence have type*mut EGLConfigwhere it had the (wrong) typeEGLConfig. Note that, if I fixed the signature problem, the bug is still here:You are always calling
eglGetConfigswith the null pointer. According to the Khronos documentation,So you'r outputting a
EGLConfigListinstance whereconfigsis always null (ouch).