Fix MSI issues and Logger handler - #50
Open
sandipklevu wants to merge 1 commit into
Open
Conversation
nileshdbabar2023
approved these changes
Aug 7, 2026
maheshganjalagunte
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a custom logging infrastructure for the SearchSpring Feed module, replacing all usages of the generic
Psr\Log\LoggerInterfacewith a new, module-specificLoggerInterface. It also implements a custom Monolog logger and handler, and refactors the MSI stock provider and resolver to improve dependency management and logging. Additional logging has been added to the feed generation process for better traceability.Logging Infrastructure Overhaul
SearchSpring\Feed\Api\LoggerInterfaceand updated all references to use this interface instead ofPsr\Log\LoggerInterface. [1] [2] [3] [4] [5] [6] [7] [8] [9]Logger/Handler.phpto define a custom log file location for SearchSpring feed logs.Logger/SearchSpringLogger.phpas a Monolog-based logger implementing the new interface.MSI Stock Provider and Resolver Refactor
MsiStockProviderto use Magento's object manager for dynamic MSI dependency resolution, improving compatibility and reducing direct dependency injection. Removed direct dependencies on MSI interfaces and replaced with runtime service resolution and caching. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]MsiStockResolverto injectMsiStockProviderandLegacyStockProviderdirectly, removing use of the global object manager and improving testability. Added caching for module enablement checks. [1] [2]Enhanced Logging in Feed Generation
GenerateFeed.php, including start, completion, and error events with contextual data. [1] [2]