Linux: Wrapper and scripts modernizations #4982

Quinn-Elara · 2025-11-12T12:43:22Z

Description

Updated SLURL handler script to prioritise letting any running viewer handle the SLURL before attempting to launch the defined default SLURL handler. Useful for if the user runs multiple different viewers on a single machine for convenience.
Updated installation scripts to utilise XDG provided tools to ensure compatibility with as many distros as possible.
Updated installation scripts to allow for multiple channels of the viewer to be installed simultaneously (e.g. Release and Beta)
Updated installation scripts to ask if user desires this viewer to be set as the default SLURL handler instead of implicitly assuming.
Updated desktop file to fix GPU selection on hybrid graphics setups.
Updated desktop file comment to utilise more common spelling of "online" (see https://www.britannica.com/dictionary/eb/qa/Online-or-on-line- )

Related Issues

Checklist

Please ensure the following before requesting review:

I have provided a clear title and detailed description for this pull request.
If useful, I have included media such as screenshots and video to show off my changes.
The PR is linked to a relevant issue with sufficient context.
I have tested the changes locally and verified they work as intended.
All new and existing tests pass.
Code follows the project's style guidelines.
Documentation has been updated if needed.
Any dependent changes have been merged and published in downstream modules
I have reviewed the contributing guidelines.

Additional Notes

These changes have been live in Alchemy's release viewers for some time now. This PR is to merge them upstream.

Suggest review from @RyeMutt .

…on and SLURL handling

Geenz · 2025-11-12T21:10:54Z

Thanks - I'll check this out when I'm in front of my Linux box again (currently on a work trip).

github-actions · 2025-11-13T23:27:25Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Quinn-Elara · 2025-11-15T09:36:08Z

I have read the CLA Document and I hereby sign the CLA

akleshchev · 2025-11-17T11:39:42Z

precommit is complaining about spaces in install.sh line 105
refresh_desktop_app_entry.sh line 61

Fixes precommit check

github-actions · 2025-12-24T00:34:20Z

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 7 days

Quinn-Elara · 2025-12-25T14:00:39Z

This branch is not stale, it is awaiting review.

akleshchev · 2025-12-25T14:26:43Z

This branch is not stale, it is awaiting review.

Removed the label. But probably not going anywhere without Rye or at least Geenz.

clairem-sl

I've left some comments.

clairem-sl · 2026-01-02T10:27:47Z

indra/newview/linux_tools/install.sh

+build_data_file="build_data.json"
+if [ -f "${build_data_file}" ]; then


This will fail if install.sh is not executed as ./install.sh.

Better to put this part after the detection of RUN_PATH, and embed $RUN_PATH in the build_data_file string.

clairem-sl · 2026-01-02T10:45:07Z

indra/newview/linux_tools/refresh_desktop_app_entry.sh

 [Desktop Entry]\n\
-Name=Second Life\n\
+Version=1.4\n\
+Name=${launcher_name}\n\
 GenericName=Second Life Viewer\n\
-Comment=Client for the On-line Virtual World, Second Life\n\
+Comment=Client for the Online Virtual World, Second Life\n\
 Path=${installation_prefix}\n\
 Exec=${installation_prefix}/secondlife\n\
-Icon=${installation_prefix}/secondlife_icon.png\n\
+Icon=${desktopfilename}\n\
 Terminal=false\n\
 Type=Application\n\
 Categories=Game;Simulation;\n\
 StartupNotify=true\n\
-StartupWMClass="com.secondlife.indra.viewer"\n\
-X-Desktop-File-Install-Version=3.0"
+StartupWMClass=\"com.secondlife.indra.viewer\"\n\
+X-Desktop-File-Install-Version=3.0
+PrefersNonDefaultGPU=true\n\
+Actions=DefaultGPU;AssociateMIME;\n\
+\n\
+[Desktop Action DefaultGPU]\n\
+Exec=env __GLX_VENDOR_LIBRARY_NAME=\"\" ${installation_prefix}/secondlife\n\
+Name=Launch on default GPU\n\
+\n\
+[Desktop Action AssociateMIME]\n\
+Exec=${installation_prefix}/etc/register_secondlifeprotocol.sh\n\
+Name=Associate SLURLs"


Why does every line end with \n\ ? We can remove all of them. The quoting during printf should keep the line breaks.

clairem-sl · 2026-01-02T11:03:26Z

indra/newview/linux_tools/install.sh

    mv "$1" "$backup_dir" || die "Failed to create backup of existing installation!"
 }

+set_slurl_handler()


Not using function

Though it is not strictly necessary, the convention seems to be using the function keyword. In addition using function makes the function stand out more.

clairem-sl · 2026-01-02T11:05:35Z

indra/newview/linux_tools/install.sh

+    echo
+    prompt "Would you like to set Second Life as your default SLurl handler? [Y/N]: "
+    if [ $? -eq 0 ]; then
+	exit 0


Shouldn't this be return 0 instead?

exit 0 ends the script completely, meaning there are steps in root_install() that will not be executed (involving "refresh_desktop_app_entry")

clairem-sl · 2026-01-02T11:10:00Z

indra/newview/linux_tools/register_secondlifeprotocol.sh

@@ -1,57 +1,66 @@
-#!/bin/bash
+#!/bin/env sh


I see no benefits running this script with sh instead of bash.

It is understandable for the actual handler to be executed by sh (which is likely much lighter -- unless it's a symlink to bash), but for this script that is invoked only during installation, better to just use bash, enabling us to use bash's powerful features.

clairem-sl · 2026-01-02T11:15:48Z

indra/newview/linux_tools/register_secondlifeprotocol.sh

+# Check if xdg-mime is present, if so, use it to register new protocol.
+if command -v xdg-mime >/dev/null 2>&1; then
+    urlhandler=$(xdg-mime query default x-scheme-handler/secondlife)
+    localappdir="${HOME}/.local/share/applications"


Shouldn't we be using ${XDG_DATA_HOME}/applications instead?

Also, this causes breakage if installation was done using sudo.

R.E. XDG_DATA_HOME - possibly, however on most systems this isn't actually set and according to the XDG spec, if it's not set then we should assume $HOME/.local/share instead.

Copilot

Pull request overview

This PR modernizes the Linux viewer installation and SLURL handling scripts to use XDG standard tools for improved cross-distribution compatibility. The changes enable multiple viewer channels to coexist on a single system and improve the SLURL handling workflow by prioritizing running viewer instances.

Replaced custom desktop registration with XDG-compliant tools (xdg-mime, xdg-desktop-menu, xdg-icon-resource)
Updated SLURL handler to check for running viewers via DBus before launching new instances
Modified installation paths to use XDG_DATA_HOME and support channel-specific installation directories

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
wrapper.sh	Commented out legacy registration calls, now handled via XDG during installation
register_secondlifeprotocol.sh	Complete rewrite to use XDG tools for protocol handler registration with channel-specific desktop files
refresh_desktop_app_entry.sh	Updated to use XDG tools for desktop entry creation, added GPU selection support and channel-based naming
install.sh	Modified to support channel-specific installation paths and prompt user for SLURL handler association
handle_secondlifeprotocol.sh	Enhanced to check for running viewers via DBus before launching new instances

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-05T20:43:42Z

indra/newview/linux_tools/register_secondlifeprotocol.sh

+    cat >"${handlerpath}" <<EOFnew || print "Warning: Did not register secondlife:// handler with xdg-mime: Could not write $newhandler"
+[Desktop Entry]
+Version=1.4
+Name="Second Life URL handler"
+Comment="secondlife:// URL handler"
+Type=Application
+Exec=$desired_handler %u
+Terminal=false
+StartupNotify=true
+NoDisplay=true
+MimeType=x-scheme-handler/secondlife
+EOFnew


The error message on line 29 is missing proper error handling. The 'cat' command will fail if it cannot write to the file, but the script continues execution regardless. The '|| print ...' only handles the output, but doesn't prevent the subsequent xdg-mime commands from running with a potentially invalid or missing desktop file. Consider using proper error handling with 'exit' or returning early.

Copilot · 2026-01-05T20:43:42Z

indra/newview/linux_tools/install.sh

+{
+    install_dir=$1
+    echo
+    prompt "Would you like to set Second Life as your default SLurl handler? [Y/N]: "


Inconsistent capitalization of 'SLurl' - should be 'SLURL' (all caps) to match the usage throughout the rest of the codebase and documentation, as seen in other files in this PR.

Suggested change

prompt "Would you like to set Second Life as your default SLurl handler? [Y/N]: "

prompt "Would you like to set Second Life as your default SLURL handler? [Y/N]: "

Copilot · 2026-01-05T20:43:43Z

indra/newview/linux_tools/register_secondlifeprotocol.sh

-NoDisplay=true\n\
-MimeType=x-scheme-handler/secondlife\n\
-X-Desktop-File-Install-Version=3.0"
+# Ensure the handle_secondlifeprotocol.sh file is executeable (otherwise, xdg-mime won't work)


Typo in comment: 'executeable' should be spelled 'executable'.

Suggested change

# Ensure the handle_secondlifeprotocol.sh file is executeable (otherwise, xdg-mime won't work)

# Ensure the handle_secondlifeprotocol.sh file is executable (otherwise, xdg-mime won't work)

Copilot · 2026-01-05T20:43:43Z

indra/newview/linux_tools/install.sh


    cp -a "${tarball_path}"/* "$1/" || die "Failed to complete the installation!"
+
+    "$1"/etc/refresh_desktop_app_entry.sh || echo "Failed to integrate into DE via XDG."


The error message 'Failed to integrate into DE via XDG.' is somewhat unclear. Consider providing more actionable information, such as 'Failed to register desktop entry. You may need to manually add the application to your menu.' This helps users understand what failed and what they might need to do.

Suggested change

"$1"/etc/refresh_desktop_app_entry.sh || echo "Failed to integrate into DE via XDG."

"$1"/etc/refresh_desktop_app_entry.sh || echo "Failed to register desktop entry via XDG. You may need to manually add the application to your desktop menu."

Copilot · 2026-01-05T20:43:43Z

indra/newview/linux_tools/register_secondlifeprotocol.sh

@@ -1,57 +1,66 @@
-#!/bin/bash
+#!/bin/env sh


The shebang should be '#!/usr/bin/env sh' instead of '#!/bin/env sh'. The standard location for 'env' on most Unix-like systems is '/usr/bin/env', not '/bin/env'. Using '/bin/env' may cause the script to fail on systems where 'env' is not in '/bin/'.

Suggested change

#!/bin/env sh

#!/usr/bin/env sh

Copilot · 2026-01-05T20:43:45Z

indra/newview/linux_tools/install.sh

+    install_dir=$1
+    echo
+    prompt "Would you like to set Second Life as your default SLurl handler? [Y/N]: "
+    if [ $? -eq 0 ]; then
+	exit 0
+    fi
+    "$install_dir"/etc/register_secondlifeprotocol.sh #Successful association comes with a notification to the user.


The variable 'install_dir' is assigned but its naming is inconsistent with the rest of the codebase which uses 'installation_prefix' or 'install_prefix'. Using a consistent naming convention would improve code maintainability.

Suggested change

install_dir=$1

echo

prompt "Would you like to set Second Life as your default SLurl handler? [Y/N]: "

if [ $? -eq 0 ]; then

exit 0

fi

"$install_dir"/etc/register_secondlifeprotocol.sh #Successful association comes with a notification to the user.

install_prefix=$1

echo

prompt "Would you like to set Second Life as your default SLurl handler? [Y/N]: "

if [ $? -eq 0 ]; then

exit 0

fi

"$install_prefix"/etc/register_secondlifeprotocol.sh #Successful association comes with a notification to the user.

Copilot · 2026-01-05T20:43:45Z

indra/newview/linux_tools/refresh_desktop_app_entry.sh

-X-Desktop-File-Install-Version=3.0"
+StartupWMClass=\"com.secondlife.indra.viewer\"\n\
+X-Desktop-File-Install-Version=3.0
+PrefersNonDefaultGPU=true\n\


Trailing newline escape sequence '\n' after 'PrefersNonDefaultGPU=true' will result in an empty line being added to the desktop file, which may not be intended. The backslash should be removed if you want the line to end there without continuation.

Copilot · 2026-01-05T20:43:46Z

indra/newview/linux_tools/handle_secondlifeprotocol.sh

 #

-URL="$1"
+sl_url="$*"


Using '$' instead of '"$@"' for capturing command-line arguments can cause issues with arguments containing spaces. The variable will contain all arguments as a single string with spaces, which means SLURLs with query parameters or special characters may not be properly preserved. Consider using '"$@"' or at least quoting '$' as '"$*"' to ensure proper argument handling.

Suggested change

sl_url="$*"

sl_url="$1"

Copilot · 2026-01-05T20:43:46Z

indra/newview/linux_tools/register_secondlifeprotocol.sh

+if command -v xdg-mime >/dev/null 2>&1; then
+    urlhandler=$(xdg-mime query default x-scheme-handler/secondlife)
+    localappdir="${HOME}/.local/share/applications"
+    newhandler="secondlifeprotocol_$(basename "${PWD%}").desktop"


The variable 'PWD%' on line 27 appears to have a typo with the trailing '%' character. This should likely be just 'PWD' without the '%' suffix, as the '%' has no meaning in this context and will be treated as a literal character.

Suggested change

newhandler="secondlifeprotocol_$(basename "${PWD%}").desktop"

newhandler="secondlifeprotocol_$(basename "${PWD}").desktop"

Copilot · 2026-01-05T20:43:46Z

indra/newview/linux_tools/install.sh

+    if [ -d "$XDG_DATA_HOME" ] ; then
+        install_to_prefix "$XDG_DATA_HOME/$installdir_name" #$XDG_DATA_HOME is a synonym for $HOME/.local/share/ unless the user has specified otherwise (unlikely).
+    else
+        install_to_prefix "$HOME/.local/share/$installdir_name" #XDG_DATA_HOME not set, so use default path as defined by XDG spec.
+    fi


The check 'if [ -d "$XDG_DATA_HOME" ]' tests if the variable is a directory, but should check if the variable is non-empty instead. If XDG_DATA_HOME is set but the directory doesn't exist yet, this will fall back to the hardcoded path instead of using the user's configured XDG_DATA_HOME. Consider using 'if [ -n "$XDG_DATA_HOME" ]' to check if the variable is set, or create the directory if it doesn't exist.

Suggested change

if [ -d "$XDG_DATA_HOME" ] ; then

install_to_prefix "$XDG_DATA_HOME/$installdir_name" #$XDG_DATA_HOME is a synonym for $HOME/.local/share/ unless the user has specified otherwise (unlikely).

else

install_to_prefix "$HOME/.local/share/$installdir_name" #XDG_DATA_HOME not set, so use default path as defined by XDG spec.

fi

if [ -n "$XDG_DATA_HOME" ] ; then

local xdg_data_dir="$XDG_DATA_HOME" # $XDG_DATA_HOME is a synonym for $HOME/.local/share/ unless the user has specified otherwise.

else

local xdg_data_dir="$HOME/.local/share" # XDG_DATA_HOME not set, so use default path as defined by XDG spec.

fi

mkdir -p "$xdg_data_dir" || die "Failed to create data directory: $xdg_data_dir"

install_to_prefix "$xdg_data_dir/$installdir_name"

Quinn-Elara · 2026-01-06T13:57:22Z

Converting to draft status while working on further modernizations and addressing feedback from other users and CoPilot's review.

Linux: Update linux scripts to use modern XDG handling for installati…

72a8fa3

…on and SLURL handling

akleshchev requested a review from Geenz November 12, 2025 20:10

Remove whitespace

d1c9d1d

Fixes precommit check

github-actions bot added the stale label Dec 24, 2025

akleshchev removed the stale label Dec 25, 2025

clairem-sl mentioned this pull request Jan 2, 2026

Fix & improve install.sh #5201

Open

9 tasks

clairem-sl reviewed Jan 2, 2026

View reviewed changes

akleshchev requested a review from Copilot January 5, 2026 20:37

Copilot started reviewing on behalf of akleshchev January 5, 2026 20:37 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

Quinn-Elara marked this pull request as draft January 6, 2026 13:56

		build_data_file="build_data.json"
		if [ -f "${build_data_file}" ]; then

	prompt "Would you like to set Second Life as your default SLurl handler? [Y/N]: "
	prompt "Would you like to set Second Life as your default SLURL handler? [Y/N]: "

	# Ensure the handle_secondlifeprotocol.sh file is executeable (otherwise, xdg-mime won't work)
	# Ensure the handle_secondlifeprotocol.sh file is executable (otherwise, xdg-mime won't work)


		cp -a "${tarball_path}"/* "$1/" \|\| die "Failed to complete the installation!"

		"$1"/etc/refresh_desktop_app_entry.sh \|\| echo "Failed to integrate into DE via XDG."

	newhandler="secondlifeprotocol_$(basename "${PWD%}").desktop"
	newhandler="secondlifeprotocol_$(basename "${PWD}").desktop"

-    if [ -d "$XDG_DATA_HOME" ] ; then
-        install_to_prefix "$XDG_DATA_HOME/$installdir_name" #$XDG_DATA_HOME is a synonym for $HOME/.local/share/ unless the user has specified otherwise (unlikely).
-    else
-        install_to_prefix "$HOME/.local/share/$installdir_name" #XDG_DATA_HOME not set, so use default path as defined by XDG spec.
-    fi
+    if [ -n "$XDG_DATA_HOME" ] ; then
+        local xdg_data_dir="$XDG_DATA_HOME" # $XDG_DATA_HOME is a synonym for $HOME/.local/share/ unless the user has specified otherwise.
+    else
+        local xdg_data_dir="$HOME/.local/share" # XDG_DATA_HOME not set, so use default path as defined by XDG spec.
+    fi
+    mkdir -p "$xdg_data_dir" || die "Failed to create data directory: $xdg_data_dir"
+    install_to_prefix "$xdg_data_dir/$installdir_name"

Linux: Wrapper and scripts modernizations #4982

Are you sure you want to change the base?

Linux: Wrapper and scripts modernizations #4982

Uh oh!

Conversation

Quinn-Elara commented Nov 12, 2025

Description

Related Issues

Checklist

Additional Notes

Uh oh!

Geenz commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Quinn-Elara commented Nov 15, 2025

Uh oh!

akleshchev commented Nov 17, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

Quinn-Elara commented Dec 25, 2025

Uh oh!

akleshchev commented Dec 25, 2025

Uh oh!

clairem-sl left a comment

Choose a reason for hiding this comment

Uh oh!

clairem-sl Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

clairem-sl Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

clairem-sl Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

clairem-sl Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

clairem-sl Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

clairem-sl Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Quinn-Elara Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 5, 2026

github-actions bot commented Nov 13, 2025 •

edited

Loading