#5046 Fix a long freeze when fetching inventory #5326
Merged
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a freeze issue when fetching large inventory messages by preventing a feedback loop between coroutines. When two large inventory messages arrive back-to-back, they were previously waking each other up repeatedly, causing a 10-second freeze.
Changes:
- Added a new
suspendUntilNextFrame()function that suspends a coroutine until the next mainloop frame tick - Modified
AISUpdate::checkTimeout()to usesuspendUntilNextFrame()instead ofsuspend()to prevent coroutines from prematurely waking each other
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| indra/llcommon/lleventcoro.h | Added declaration for new suspendUntilNextFrame() function |
| indra/llcommon/lleventcoro.cpp | Implemented suspendUntilNextFrame() to wait for mainloop's newFrame event |
| indra/newview/llaisapi.cpp | Changed timeout handling to use suspendUntilNextFrame() instead of suspend() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5086_guide
branch
from
401bffc to
17ec9d8
Compare
maxim-productengine
approved these changes
Jan 23, 2026
marchcat
approved these changes
Jan 24, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look like there is a feedback loop going on. If two large inventory messages arrive back to back, message A would work foe a short periood then supends, B wakes up, B would work then suspends and A would wake up, loop continues untill work is done 10 secodns later...
P.S. Fix appears to work as intended, but there are odities around this issue that make me think that more might be needed. Sadly corotines do not work with tracy and checking them is a time consuming process, so unless I see a proof of other problems this will have to be enough.