-
Notifications
You must be signed in to change notification settings - Fork 99
Add luau-lsp files to the viewer #5327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: project/lua_editor
Are you sure you want to change the base?
Conversation
|
Thank you, @tapple! |
|
@Rider-Linden, please take a look. |
|
The Delivering the JSON and having the plugin generate the appropriate configs file strikes me the correct approach. I don't object to providing these two files as a reference but it should be made clear that they are not canonical. |
|
These ones I found use JohnnyMorganz luau-lsp:
I can't quickly find any editors supporting luau that don't use JohnnyMorganz luau-lsp |
|
Hmm, realistically, |
|
Spoke with @Rider-Linden about this. Seems like really what we want is to send down the current contents of the definitions YAML (maybe reserialized as JSON for the JSON-RPC stuff) to external consumers, rather than bundle a generated artifact from that source of truth that the viewer itself will not use. The keywords XML will probably have to remain in-repo because the in-viewer editor's syntax highlighting impl is a bit of a weird case, but otherwise we're looking at providing a way for the JSON-RPC clients to get the full definitions blob the server is currently using. They can generate whatever schema they want ( |
|
Oh. Selene uses a third format I was unaware of: https://kampfkarren.github.io/selene/usage/std.html If that's the official consensus though, I guess I'll work on generating types_lua.xml and updating the vscode plugin to work with the changes I made to its schema |
These are the two files that any installation of the Luau Language Server (luau-lsp) needs to make sense of slua code. Currently, vscode plugin builds these two files based on these two files it fetches from the viewer:
Instead, I propose the viewer and/or simulator keep these two files on-hand so that the vscode plugin and other editors (including the viewer's builtin editor) can handle slua without complex file transformation.
These two files were generated by the latest unreleased version of the vscode plugin. Further auto-generated updates to these files will be in a seperate PR #5328 (View the diff)
Part of a set:
slua_default.d.luaufile lsl-definitions#42