#5335 Fix silent uninstall asking about registry #5340
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Windows NSIS uninstaller script to better support non-interactive uninstalls and to add an explicit flag to clear registry keys without prompting.
Changes:
- Skips the “Delete program files” confirmation dialog when
$SKIP_DIALOGSis set. - Adds support for a
/clearregcommand-line option intended to clear registry keys without prompting the user. - Refactors the registry deletion confirmation flow to branch based on the new option and
$SKIP_DIALOGS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5335
branch
2 times, most recently
from
85c4058 to
b448d5e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5335
branch
from
b448d5e to
5f08f8d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5335
branch
2 times, most recently
from
f476e4f to
15764c0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5335
branch
from
15764c0 to
224d7fc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix silent uninstall asking about registry. Add an argument to clear registry without asking.