#2975 PBR support for planar aligment #5347
Merged
+192
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since checkbox is shared between pbr and normal textures, I'm making it affect both for now.
akleshchev
force-pushed
the
andreyk/viewer_2975
branch
from
2ba82a4 to
35ffd37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since checkbox is shared between pbr and normal textures, I'm making it affect both for now. 'Align' button appears to be texture specific so not touching that.
Had to reimplement texture->PBR transform conversions as that was utilizing incorrect rotation and as a result offsets.
P.S. For whatever reason selection outlines are incorrect. But decided not to touch them for now.