Skip to content

chore: expose public root_path #413

Open
FollyCoolly wants to merge 2 commits into
mainfrom
zhsu/expose-store-root-path
Open

chore: expose public root_path #413
FollyCoolly wants to merge 2 commits into
mainfrom
zhsu/expose-store-root-path

Conversation

@FollyCoolly

Copy link
Copy Markdown
Contributor

No description provided.

@FollyCoolly FollyCoolly requested a review from a team as a code owner June 3, 2026 11:42

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a root_path property to StoreBackend and a persistent property to the object store class. A review comment correctly points out that the persistent property is already defined later in the file, making the new definition redundant and prone to being overwritten.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread mplang/runtime/object_store.py Outdated
Addresses PR #413 review: the `persistent` property was defined twice;
removed the redundant earlier definition and kept the one in the
Convenience section.

@tongke6 tongke6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes the storage backend’s configured root_path as a public read-only property on StoreBackend, making it accessible to callers without reaching into the internal _root_path.

Changes:

  • Added StoreBackend.root_path property returning the configured base path (or None for backends without a root path).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants