-
Notifications
You must be signed in to change notification settings - Fork 1
fix: increase search result timeout from 5s to 15s #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kristian Da Costa Menezes <kdacosta@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtends the Playwright-based UI test wait timeout for search result cards from 5 seconds to 15 seconds to reduce test flakiness when search results are slow to appear. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider keeping the numeric separator for readability (e.g.,
15_000instead of15000) to be consistent with the previous style and make the timeout value easier to scan. - You might want to extract the timeout value into a named constant (e.g.,
searchResultTimeout) so it’s easier to adjust in one place and self-documents the purpose of the 15s delay.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider keeping the numeric separator for readability (e.g., `15_000` instead of `15000`) to be consistent with the previous style and make the timeout value easier to scan.
- You might want to extract the timeout value into a named constant (e.g., `searchResultTimeout`) so it’s easier to adjust in one place and self-documents the purpose of the 15s delay.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
tests failing on timeout for commitSHA scenario https://github.com/securesign/secure-sign-operator/actions/runs/19761596361/job/56624843082?pr=1478 |
Summary by Sourcery
Tests: