Open
Conversation
The script merges the "Processes" table and "input_output" table. `default` parameters are set for the processes from "Process" table.
henhuy
requested changes
May 2, 2023
Collaborator
henhuy
left a comment
henhuy
left a comment
There was a problem hiding this comment.
Reading Excel and ES structure look good.
Writing structure and importing it via structure module fails due to wrong otuput type (Excel instead of CSV) and wrong delimiter (comma instead of semicolon) used.
Could you fix it?
Best would be to add test for writing structure CSV and importing ti via structure.get_energy_structure.
Therefore, see also how to add a file temporarilly (is deleted afterwards):
data_adapter/tests/test_databus.py
Line 36 in 6b66c6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20