Open
Conversation
…umns Feature/eliminate empty columns
SabineHaas
reviewed
Sep 12, 2024
SabineHaas
left a comment
There was a problem hiding this comment.
Thanks a lot @yechenyan! looks good to me!
I won't merge, as I am not sure whether it will be part of this adapter or another repo.
However, I have used the function to get all the inputs for the emission constraint, which was very helpful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new function,
process_emission_constraint_inputs(processes_raw), aims to refine the handling of emission constraint data. Below is the detailed workflow and expected transformation:The input(
processes_raw) to the function is a pandasDataFrameas shown below:The return value of the function is a pandas
DataFrame, which update the last row as below:Processing Steps:
If there's a row in the table where the process is
ind_constraintco_2eq, then execute the subsequent steps.Take all the values in the
outputcolumn that start withemi, remove duplicates, and place them into theinputfield of the row where the process isind_constraintco_2eq.Beside, implement necessary test cases to verify the function's effectiveness and accuracy.