fix(activity): use source document for comment mention notifications#694
Open
ericvicenti wants to merge 1 commit into
Open
fix(activity): use source document for comment mention notifications#694ericvicenti wants to merge 1 commit into
ericvicenti wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #693.
In
ActivityFeed.ListEvents, comment mention events were incorrectly settingnewMention.sourceDocumentto the mention target. For account/profile mentions, that meant the source document becamehm://<mentioned-account>/:profile, causing notification titles likementioned you in :profileand causing web site-scoped inbox filtering to hide the notification.This PR keeps
newMention.targetas the mentioned entity, but setsnewMention.sourceDocumentfrom the comment blob's resource IRI.Changes
SourceDocumentwhen the mention source blob is aComment.hm://<account>/:profileinsidehm://<author>/doc.Validation
go test ./backend/api/activity/v1alpha