Skip to content

Conversation

@Prithviraj-rathore-segment
Copy link
Contributor

JIRA

https://twilio-engineering.atlassian.net/browse/STRATCONN-6302

A summary of your pull request, including the what change you're making and why.

Description

  1. This PR includes changes for making the fields secret in cloud mode and browser mode destinations.
  2. Changes include the type: password for the secret fields

Testing

Testing done in staging environment . please find the attached testing document .
https://docs.google.com/document/d/1TOiGnM0iUwstZIby_wZE-EqsJAMppRPWIecrbdXqRXI/edit?tab=t.0

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.05%. Comparing base (25481e8) to head (6033c17).

Files with missing lines Patch % Lines
...nation-actions/src/destinations/outfunnel/index.ts 85.71% 1 Missing ⚠️
...ation-actions/src/destinations/xtremepush/index.ts 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (77.77%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3448   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files        1224     1224           
  Lines       22712    22712           
  Branches     4503     4502    -1     
=======================================
  Hits        18181    18181           
  Misses       3699     3699           
  Partials      832      832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants