Skip to content

Conversation

@arajasek
Copy link
Contributor

We don't know whether pending txs will actually ever land, so they can throw off our metrics for utilization and priority reservoir.

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 5, 2026, 3:26 PM

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.79%. Comparing base (354a415) to head (2f6c13d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/mempool/mempool.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
- Coverage   46.38%   43.79%   -2.60%     
==========================================
  Files        1237     1904     +667     
  Lines      108362   158932   +50570     
==========================================
+ Hits        50265    69604   +19339     
- Misses      53489    82931   +29442     
- Partials     4608     6397    +1789     
Flag Coverage Δ
sei-chain 45.83% <ø> (+0.02%) ⬆️
sei-cosmos 38.20% <ø> (?)
sei-db 69.28% <ø> (+0.21%) ⬆️
sei-tendermint 47.31% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/mempool/mempool.go 67.78% <50.00%> (ø)

... and 687 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


func (txmp *TxMempool) utilisation() float64 {
return float64(txmp.Size()) / float64(txmp.config.Size)
return float64(txmp.NumTxsNotPending()) / float64(txmp.config.Size)

Check notice

Code scanning / CodeQL

Floating point arithmetic Note

Floating point arithmetic operations are not associative and a possible source of non-determinism
@arajasek arajasek requested a review from masih January 5, 2026 15:11
@arajasek arajasek force-pushed the asr/fix-mempool-spam branch from 38b3891 to f196006 Compare January 5, 2026 15:11
Copy link
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @arajasek 🍻

@sei-will sei-will self-requested a review January 5, 2026 15:24
@arajasek arajasek enabled auto-merge (squash) January 5, 2026 15:24
@arajasek arajasek force-pushed the asr/fix-mempool-spam branch from f196006 to 2f6c13d Compare January 5, 2026 15:25
@arajasek arajasek merged commit 9fda687 into main Jan 5, 2026
38 of 39 checks passed
@arajasek arajasek deleted the asr/fix-mempool-spam branch January 5, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants