-
Notifications
You must be signed in to change notification settings - Fork 858
feat: mempool: don't add pending txs to priority reservoir #2641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
- Coverage 46.38% 43.79% -2.60%
==========================================
Files 1237 1904 +667
Lines 108362 158932 +50570
==========================================
+ Hits 50265 69604 +19339
- Misses 53489 82931 +29442
- Partials 4608 6397 +1789
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
|
||
| func (txmp *TxMempool) utilisation() float64 { | ||
| return float64(txmp.Size()) / float64(txmp.config.Size) | ||
| return float64(txmp.NumTxsNotPending()) / float64(txmp.config.Size) |
Check notice
Code scanning / CodeQL
Floating point arithmetic Note
38b3891 to
f196006
Compare
masih
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks @arajasek 🍻
f196006 to
2f6c13d
Compare
We don't know whether pending txs will actually ever land, so they can throw off our metrics for utilization and priority reservoir.