fixed support for AllowEmptyBlocks = false for autobahn #3739
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -476,11 +476,6 @@ type App struct { | |
|
|
||
| forkInitializer func(sdk.Context) | ||
|
|
||
| // evmHTTPServer/evmWSServer hold the EVM JSON-RPC HTTP and WebSocket listeners | ||
| // constructed in RegisterLocalServices so an embedding orchestrator (the | ||
| // in-process harness) can Stop() them at teardown. Nil when the respective | ||
|
|
@@ -539,21 +534,19 @@ func New( | |
| memKeys := sdk.NewMemoryStoreKeys(capabilitytypes.MemStoreKey, banktypes.DeferredCacheStoreKey, oracletypes.MemStoreKey) | ||
|
|
||
| app := &App{ | ||
| BaseApp: bApp, | ||
| cdc: cdc, | ||
| appCodec: appCodec, | ||
| interfaceRegistry: interfaceRegistry, | ||
| keys: keys, | ||
| tkeys: tkeys, | ||
| memKeys: memKeys, | ||
| txDecoder: encodingConfig.TxConfig.TxDecoder(), | ||
| versionInfo: version.NewInfo(), | ||
| metricCounter: &map[string]float32{}, | ||
| encodingConfig: encodingConfig, | ||
| legacyEncodingConfig: MakeLegacyEncodingConfig(), | ||
| stateStore: stateStore, | ||
| } | ||
|
|
||
| for _, option := range appOptions { | ||
|
|
@@ -1946,17 +1939,6 @@ func (app *App) ProcessBlock(ctx sdk.Context, txs [][]byte, req *BlockProcessReq | |
| } | ||
| }() | ||
|
|
||
| ctx = ctx.WithIsOCCEnabled(app.OccEnabled()) | ||
|
|
||
| blockSpanCtx, blockSpan := app.GetBaseApp().TracingInfo.Start("Block") | ||
|
|
@@ -2061,13 +2043,17 @@ func (app *App) executeEVMTxWithGigaExecutor(ctx sdk.Context, msg *evmtypes.MsgE | |
| }, nil | ||
| } | ||
|
|
||
| // Prepare context for EVM transaction (set infinite gas meter like original flow) | ||
| ctx = ctx.WithGasMeter(sdk.NewInfiniteGasMeterWithMultiplier(ctx)) | ||
|
|
||
| _, isAssociated := app.GigaEvmKeeper.GetEVMAddress(ctx, seiAddr) | ||
|
|
||
| // Create state DB before validation so balance checks use DBImpl hooks. | ||
| stateDB := gigaevmstate.NewDBImpl(ctx, &app.GigaEvmKeeper, false) | ||
| defer stateDB.Cleanup() | ||
|
|
||
| // Run validation checks (fee/nonce/balance - stateless checks done earlier) | ||
| validation := app.validateGigaEVMTx(ctx, stateDB, ethTx, sender, seiAddr, isAssociated) | ||
|
|
||
| if validation.err != nil { | ||
| // v2 rejects fee/nonce/balance failures in its ante chain, whose | ||
|
|
@@ -2092,10 +2078,6 @@ func (app *App) executeEVMTxWithGigaExecutor(ctx sdk.Context, msg *evmtypes.MsgE | |
| return nil, gigaprecompiles.ErrBalanceMigrationRequired | ||
| } | ||
|
|
||
| // Pre-charge gas fee (like V2's ante handler), then execute with feeAlreadyCharged=true. | ||
| // V2 charges fees in the ante handler, then runs the EVM with feeAlreadyCharged=true | ||
| // which skips buyGas/refundGas/coinbase. Without this, GasUsed differs between Giga | ||
|
|
@@ -2640,19 +2622,7 @@ func (app *App) LegacyAmino() *codec.LegacyAmino { | |
| } | ||
|
|
||
| func (app *App) GetValidators() []abci.ValidatorUpdate { | ||
| return app.StakingKeeper.GetBondedValidators(app.GetCheckCtx()) | ||
|
There was a problem hiding this comment. Validators read raced check stateMedium Severity
Additional Locations (1)  Reviewed by Cursor Bugbot for commit 809f5a7. Configure here. |
||
| } | ||
|
|
||
| // AppCodec returns an app codec. | ||
|
|
@@ -2811,7 +2781,7 @@ func (app *App) RegisterLocalServices(node client.LocalClient, txConfig client.T | |
| } | ||
| app.evmHTTPServer = evmHTTPServer | ||
| go func() { | ||
| <-app.Initialized() | ||
| if err := evmHTTPServer.Start(); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
@@ -2826,7 +2796,7 @@ func (app *App) RegisterLocalServices(node client.LocalClient, txConfig client.T | |
| } | ||
| app.evmWSServer = evmWSServer | ||
| go func() { | ||
| <-app.Initialized() | ||
| if err := evmWSServer.Start(); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
@@ -3085,6 +3055,7 @@ type gigaValidationResult struct { | |
| // 7. Balance check | ||
| func (app *App) validateGigaEVMTx( | ||
| ctx sdk.Context, | ||
| stateDB *gigaevmstate.DBImpl, | ||
| ethTx *ethtypes.Transaction, | ||
| sender common.Address, | ||
| seiAddr sdk.AccAddress, | ||
|
|
@@ -3235,13 +3206,17 @@ func (app *App) validateGigaEVMTx( | |
| balanceCheck := new(big.Int).Mul(new(big.Int).SetUint64(ethTx.Gas()), ethTx.GasFeeCap()) | ||
| balanceCheck.Add(balanceCheck, ethTx.Value()) | ||
|
|
||
| // Route validation balance reads through DBImpl so mock_balances follows | ||
| // the same ensureMinimumBalance behavior as V2's StateTransition.BuyGas. | ||
| senderBalance := stateDB.GetBalance(sender).ToBig() | ||
|
|
||
| // Include the derived Sei address balance for unassociated addresses (matches V2 PreprocessDecorator). | ||
| if !isAssociated { | ||
| seiEVMAddr := common.BytesToAddress(seiAddr) | ||
| if seiEVMAddr != sender { | ||
| seiBalance := stateDB.GetBalance(seiEVMAddr).ToBig() | ||
| senderBalance = new(big.Int).Add(senderBalance, seiBalance) | ||
| } | ||
| } | ||
|
|
||
| if senderBalance.Cmp(balanceCheck) < 0 { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genesis gentx ante checks incomplete
High Severity
SetGasMeterandCheckSignaturesdropped the height-0 genesis special cases without switching toctx.IsGenesis(), unlikeGetGasMeterSetterand the classicSigVerificationDecorator.InitChainnow delivers gentxs on anIsGenesiscontext throughCosmosDeliverTxAnte, so gentxs signed with account number 0 can fail signature verification and lose infinite-gas genesis metering.Additional Locations (1)
app/ante/cosmos_checktx.go#L446-L453Reviewed by Cursor Bugbot for commit 7959d12. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosmos_checktx.go does not belong to the initChainer path. It does not need the special case.