Added the flexibility to not reverse the domain labels during normalization#1
Open
plaurina wants to merge 3 commits intosentric:masterfrom
Open
Added the flexibility to not reverse the domain labels during normalization#1plaurina wants to merge 3 commits intosentric:masterfrom
plaurina wants to merge 3 commits intosentric:masterfrom
Conversation
Author
|
Well, it no longer order the domain parts, which was the intent, but it does order the parameters. Also, one thing I'm likely to add is something the java.net.URI.Normalize() method does. It normalizes the path on the URI as well, removing any . or .. paths appropriately. ie. http://example.com/test/../ is equivalent to http://example.com -Pete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For people using URL.getNormalizedUrl() their functionality will not change, but I added a method signature that allows a boolean to this that will not reverse the domain labels.
-Pete