decomp func_800C64D0 - #44
Conversation
ser-pounce
left a comment
ser-pounce
left a comment
There was a problem hiding this comment.
Thanks for the PR! The call to func_800C64D0 inside func_8007A824 also needs addressing as it issues a couple of warnings, let me know if you need anything.
|
Think I fixed the issue. Please let me know if I didn't. |
ser-pounce
left a comment
ser-pounce
left a comment
There was a problem hiding this comment.
And you can change the declaration of D_800F1870 from int to void*.
Sorry if I'm being pedantic with the change requests, your submission is perfectly fine already, I'm just trying to save us both some time down the line. Basically, if you need to introduce a cast, it's quite likely that the thing your casting has the wrong type; this one is very straightforward because it's only used here, if you encounter something more complex don't worry about it if it's too much and leave the cast. Thanks!
Co-authored-by: ser-pounce <ser-pounce@users.noreply.github.com>
|
Don't worry about being pedantic, I really appreciate the feedback |
2 participants
decompiled
func_800C64D0insrc/BATTLE/BATTLE.PRG/5BF94.cwith some help from ser-pounce. Also updatedsrc/BATTLE/BATTLE.PRG/146C.cto use the updated data types in the function declaration