Skip to content

UI Changes #41 and #48 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amitg87 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

UI Changes #41 and #48 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62b0735
issue #25 fixed - extension install type differentiator
May 18, 2018
cca50bd
profile edit view changed
May 21, 2018
5b4b6a6
merge upstream
Jun 5, 2018
c69929b
ungrouped apps and extension
Jun 8, 2018
26761c3
merge master
Aug 29, 2019
7eed6f5
description as titles for names/icons and homepage link in options page
Aug 29, 2019
643564a
title update
Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<body>
<section id="header" class="main" data-sbind="if: opts.showHeader">
<h1>
<a id="title" href="https://chrome.google.com/webstore/detail/jjmflmamggggndanpgfnpelongoepncg" target="_blank"><img src="images/icon48.png" width="16px" height="16px" />&nbsp;Extensity</a>
<a id="title" class="icon" href="https://chrome.google.com/webstore/detail/jjmflmamggggndanpgfnpelongoepncg" target="_blank"><img src="images/icon48.png"/>&nbsp;Extensity</a>

<!-- Actions -->
<a href="https://chrome.google.com/webstore/detail/extensity/jjmflmamggggndanpgfnpelongoepncg/reviews" class="page" target="_blank"><i class="fa fa-star" alt="Rate Extensity. Thanks!" title="Rate Extensity. Thanks!"></i></a>
Expand Down Expand Up @@ -86,17 +86,20 @@ <h1 data-sbind="visible: listedItems.any">Extensions &amp; Apps</h1>

<script type="text/html" id="item-template">
<!-- ko if: !isApp() -->
<li class="extension" data-sbind="click: $parent.toggleExtension, css:{disabled: disabled}"><img width="16px" height="16px" data-sbind="attr:{src:icon}" />
<span data-sbind="text: short_name"></span>
<li class="extension" data-sbind="click: $parent.toggleExtension, css:{disabled: disabled}">
<img class="icon" data-sbind="attr:{src:icon, title: description}" />
<span data-sbind="text: short_name, attr: {title: description}"></span>
<i class="fa fa-flask" title="Development" alt="Development" data-sbind="visible: is_development"></i>
<i class="fa fa-home" title="Open in Chrome Store" alt="Open in Chrome Store" data-sbind="click: $parent.launchHomePage, clickBubble: false"></i>
<i class="fa fa-gear" title="Options" alt="Options" data-sbind="visible: $parent.opts.showOptions() && optionsUrl() && !disabled(), click: $parent.launchOptions, clickBubble: false"></i>

</li>
<!-- /ko -->
<!-- ko if: isApp() -->
<li class="app" data-sbind="click: $parent.launchApp">
<img width="16px" height="16px" data-sbind="attr:{src:icon}"/> <span data-sbind="text: short_name"></span>
<img class="icon" data-sbind="attr:{src:icon, title: description}"/>
<span data-sbind="text: short_name, attr: {title: description}"></span>
<i class="fa fa-flask" title="Development" alt="Development" data-sbind="visible: is_development"></i>
<i class="fa fa-home" title="Open in Chrome Store" alt="Open in Chrome Store" data-sbind="click: $parent.launchHomePage, clickBubble: false"></i>
<i class="fa fa-gear" title="Options" alt="Options" data-sbind="visible: $parent.opts.showOptions() && optionsUrl() && !disabled(), click: $parent.launchOptions, clickBubble: false"></i>
</li>
<!-- /ko -->
Expand Down
2 changes: 2 additions & 0 deletions js/engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ var ExtensionModel = function(e) {
self.status = ko.observable(item.enabled);
self.optionsUrl = ko.observable(item.optionsUrl);
self.installType = ko.observable(item.installType);
self.description = ko.observable(item.description);
self.homepageUrl = ko.observable(item.homepageUrl);

self.disabled = ko.pureComputed(function() {
return !self.status();
Expand Down
4 changes: 4 additions & 0 deletions js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ document.addEventListener("DOMContentLoaded", function() {
chrome.tabs.create({url: ext.optionsUrl(), active: true});
};

self.launchHomePage = function(ext) {
chrome.tabs.create({url: ext.homepageUrl(), active: true});
};

self.listedExtensions = ko.computed(function() {
// Sorted/Filtered list of extensions
return (self.opts.enabledFirst()) ?
Expand Down
4 changes: 2 additions & 2 deletions profiles.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ <h1><img src="images/icon48.png" /> Extensity Options</h1>
<li>
<label data-sbind="attr:{for:id}">
<input type="checkbox" data-sbind="value: id, attr:{id: id, name:id}, checked: $parent.current_profile().items" />
<img data-sbind="attr:{src: icon}" width="16px" height="16px" />
<span data-sbind="text: short_name"></span>
<img class="icon" data-sbind="attr:{src: icon, title: description}"/>
<span data-sbind="text: short_name, attr: {title: description}"></span>
<i class="fa fa-flask" title="Development" alt="Development" data-sbind="visible: is_development"></i>
</label>
</li>
Expand Down
10 changes: 8 additions & 2 deletions styles/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ a {
text-decoration: none;
}

img.icon {
height: 16px;
widows: 16px;
}

section.main {
float: left;
clear: both;
Expand Down Expand Up @@ -179,14 +184,15 @@ section#content li.disabled img {
opacity: 0.3;
}

section#content li i.fa-gear {
section#content li i.fa-gear, section#content li i.fa-home {
float: right;
margin-top: 2px;
color: #777;
font-size: 1.1em;
padding-right: 2px;
}

section#content li i.fa-gear:hover {
section#content li i.fa-gear:hover, section#content li i.fa-home:hover {
color: #333;
}

Expand Down
2 changes: 1 addition & 1 deletion styles/options.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ fieldset#options .field {
}

#profiles .extensions {
border-left: 1px solid #ddd;
border: 1px solid #ddd;
padding-left: 10px;
padding-right: 10px;
}
Expand Down