Skip to content

Conversation

@Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Jan 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 5, 2026 05:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the network page by converting inline SVG React components to actual SVG files, using SVGR webpack loader to generate React components from them at build time. This reduces bundle size and improves maintainability.

Key changes:

  • Converts 10 inline SVG React components (NodeGraph1-10) to standalone SVG files
  • Adds webpack configuration with @svgr/webpack to process SVG files
  • Migrates styled-components props to transient props (prefixed with $) to prevent DOM warnings
  • Adds a mock feature flag for testing different node counts in the network page

Reviewed changes

Copilot reviewed 26 out of 39 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
yarn.lock Added @svgr/webpack and related dependencies for SVG processing
package.json Added @svgr/webpack dependency and build:svg script
svgs.webpack.config.js New webpack config for compiling SVG files to React components
ts/svgs/tsconfig.json TypeScript config for SVG compilation
ts/svgs/svg.d.ts Type definitions for SVG imports
ts/svgs/node-graph/*.svg 10 new SVG files extracted from React components
ts/svgs/index.ts Exports for all SVG components
ts/components/dialog/user-settings/pages/network/NodeImage.tsx Refactored to use imported SVG components and CSS variables
ts/components/dialog/user-settings/pages/network/nodes/NodeGraph*.tsx Deleted - replaced with SVG files
ts/components/dialog/user-settings/pages/network/sections/network/NetworkSection.tsx Fixed styled-components transient props, removed unused variables
ts/components/dialog/user-settings/pages/network/sections/StakeSection.tsx Fixed styled-components transient props
ts/components/dialog/user-settings/pages/network/components.tsx Migrated props to transient props
ts/components/dialog/user-settings/pages/network/SessionNetworkPage.tsx Fixed transient prop usage
ts/components/basic/Flex.tsx Migrated overflow props to transient props
ts/components/loading/spinner/AnimatedSpinnerIcon.tsx Fixed SVG attribute names (camelCase)
ts/components/conversation/composition/CompositionBox.tsx Removed unused JSX import
ts/state/ducks/types/releasedFeaturesReduxTypes.ts Added mockNetworkPageNodeCount feature flag
ts/state/ducks/types/defaultFeatureFlags.ts Added default value for mockNetworkPageNodeCount
ts/components/dialog/debug/FeatureFlags.tsx Added min/max support and mockNetworkPageNodeCount input

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Aerilym
Copy link
Collaborator Author

Aerilym commented Jan 5, 2026

@Bilb build is failing because of react compiler, but this is fixed in #1755 so once that is in dev this will build

Bilb
Bilb previously approved these changes Jan 5, 2026
@Bilb Bilb merged commit c131fe5 into dev Jan 5, 2026
8 checks passed
@Bilb Bilb deleted the fix/optimise_network_page_images branch January 5, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants