Skip to content

Conversation

@toopay
Copy link
Member

@toopay toopay commented Oct 24, 2024

Description

It seems the feature is able to generate the model, but after updating the tag, it still tries to generate the same tag (see screenshot).

Fixes #74

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Unit Tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Screenshot 2024-10-22 at 20 35 46

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
-race 71.61% <100.00%> (+0.03%) ⬆️
-tags "sonic avx" 71.64% <100.00%> (+0.05%) ⬆️
-tags go_json 71.64% <100.00%> (+0.05%) ⬆️
-tags nomsgpack 71.64% <100.00%> (+0.06%) ⬆️
go-1.21 71.56% <100.00%> (+0.04%) ⬆️
go-1.22 71.64% <100.00%> (+0.05%) ⬆️
macos-latest 71.66% <100.00%> (+0.04%) ⬆️
ubuntu-latest 71.64% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/generator/model.go 82.70% <100.00%> (+0.19%) ⬆️
pkg/resource/import.go 80.95% <100.00%> (+0.05%) ⬆️
pkg/resource/tables/compare.go 76.82% <100.00%> (+0.40%) ⬆️
pkg/state/table.go 74.05% <100.00%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto index foreign key

2 participants