Fix region edge cases and improve test coverage#262
Merged
tomwhite merged 3 commits intosgkit-dev:mainfrom Feb 19, 2026
Merged
Conversation
Member
Author
|
Added an improvement in c96edee which will make region queries much more efficient, when for example there is a region at the beginning and another region at the end of a file ( |
jeromekelleher
approved these changes
Feb 19, 2026
Member
|
Could the edge case fixed here result in retrieval bugs? If so we should document in the changelog. |
tomwhite
force-pushed
the
region-edge-case-fixes
branch
from
6cd62b3 to
0df5992
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise the region tests better by parameterizing over chunk size.