Skip to content

Diff review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgysherry wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Diff review #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d1d2cb
Add monitoring XIDs list
sgysherry Apr 25, 2025
15e0ff1
Update vendor
sgysherry May 1, 2025
8305742
Update vendor
sgysherry May 1, 2025
69cde05
Add unittests
sgysherry Jun 12, 2025
d48e886
Add XID event
sgysherry Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ presubmit: vet
@./build/check_boilerplate.sh

TAG=$(shell cat VERSION)
REGISTRY?=gcr.io/google-containers
REGISTRY?=us-west1-docker.pkg.dev/yshangguan-gke-dev/sgy-test-image
IMAGE=nvidia-gpu-device-plugin
PARTITION_GPU_IMAGE=nvidia-partition-gpu
FASTSOCKET_INSTALLER_IMAGE=fastsocket-installer
Expand Down
8 changes: 7 additions & 1 deletion cmd/nvidia_gpu/nvidia_gpu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
gpumanager "github.com/GoogleCloudPlatform/container-engine-accelerators/pkg/gpu/nvidia"
healthcheck "github.com/GoogleCloudPlatform/container-engine-accelerators/pkg/gpu/nvidia/health_check"
"github.com/GoogleCloudPlatform/container-engine-accelerators/pkg/gpu/nvidia/metrics"
util "github.com/GoogleCloudPlatform/container-engine-accelerators/pkg/gpu/nvidia/util"
"github.com/NVIDIA/go-nvml/pkg/nvml"
"github.com/golang/glog"
pluginapi "k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1"
Expand Down Expand Up @@ -139,7 +140,12 @@ func main() {
}

if *enableHealthMonitoring {
hc := healthcheck.NewGPUHealthChecker(ngm.ListPhysicalDevices(), ngm.Health, ngm.ListHealthCriticalXid())
kubeClient, err := util.BuildKubeClient()
if err != nil {
glog.Infof("Failed to build kube client: %v", err)
return
}
hc := healthcheck.NewGPUHealthChecker(ngm.ListPhysicalDevices(), ngm.Health, ngm.ListHealthCriticalXid(), kubeClient)
if err := hc.Start(); err != nil {
glog.Infof("Failed to start GPU Health Checker: %v", err)
return
Expand Down
95 changes: 0 additions & 95 deletions daemonset.yaml
View file
Open in desktop

This file was deleted.

Loading