Fix static c-ares detection for c-ares >= 1.27#3025
Open
Conversation
c-ares >= 1.27 renamed the static library from libcares.a to libcares_static.a. Search for both names so the static build works on older distros (libcares.a) and newer ones (libcares_static.a). Fixes #3024 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WITH_STATIC defaults to ON in CMakeLists.txt but CI was explicitly disabling it. Remove -DWITH_STATIC=OFF so the static targets are also built and linked, catching issues like the c-ares static library rename (#3024). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libcares.atolibcares_static.afind_library(LIBUDNS libcares.a)call fails on these newer systems, breaking the static buildfind_library(LIBUDNS NAMES libcares.a libcares_static.a)to search for both names, maintaining backward compatibility with older distrosFixes #3024
Test plan
libcares_static.a)libcares.a)🤖 Generated with Claude Code