Merged
Conversation
Gnito
force-pushed
the
refactor-AuthenticationPage
branch
from
4c85c31 to
61a4b6b
Compare
Gnito
force-pushed
the
refactor-SearchPage
branch
from
a5eb189 to
afee173
Compare
Gnito
force-pushed
the
refactor-AuthenticationPage
branch
from
61a4b6b to
8dd491a
Compare
Gnito
force-pushed
the
refactor-SearchPage
branch
from
afee173 to
a7b26ff
Compare
Gnito
force-pushed
the
refactor-AuthenticationPage
branch
from
8dd491a to
b95333e
Compare
- getDerivedRenderData - onApplyFilters - onSortBy - onResetAll - createFilterValueChangeHandler
Gnito
force-pushed
the
refactor-SearchPage
branch
from
a7b26ff to
3edb715
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explore options to reduce duplicated code between search page variants.