updated device names to match dyson names and models#28
updated device names to match dyson names and models#28nberardi wants to merge 1 commit intoshenxn:mainfrom
Conversation
dotvezz
left a comment
dotvezz
left a comment
There was a problem hiding this comment.
Great intent! However, some of these updates are explicitly incorrect, I think they would lead to more serious confusion.
| DEVICE_TYPE_PURE_COOL_LINK: "Pure Cool Link (TP02)", | ||
| DEVICE_TYPE_PURE_COOL_LINK_DESK: "Pure Cool Desk (DP01)", | ||
| DEVICE_TYPE_PURE_HOT_COOL: "Pure Hot+Cool (HP04)", | ||
| DEVICE_TYPE_PURE_HOT_COOL_NEW: "Purifier Hot+Cool Formaldehyde (HP07/HP09)", |
There was a problem hiding this comment.
I'm pretty sure this is incorrect.
DEVICE_TYPE_PURE_HOT_COOL_NEW is "527E" which is Formaldehyde HP09. However, the code for HP07 is "527K" and it is not a Formaldehyde model.
| DEVICE_TYPE_PURE_HOT_COOL_NEW: "Purifier Hot+Cool Formaldehyde (HP07/HP09)", | ||
| DEVICE_TYPE_PURE_HOT_COOL_LINK: "Pure Hot+Cool Link (HP02)", | ||
| DEVICE_TYPE_PURE_HUMIDIFY_COOL: "Pure Humidify+Cool (PH01)", | ||
| DEVICE_TYPE_PURIFIER_HUMIDIFY_COOL_FORMALDEHYDE: "Pure Humidify+Cool Formaldehyde (PH03/PH04)", |
There was a problem hiding this comment.
I believe this change is also incorrect. PH03 and PH04 are both "Dyson Purifier" and not "Dyson Pure" models.
Reference: https://www.dyson.com/air-treatment/air-purifier-humidifiers/purifier-humidify-cool-ph03/white-silver.
Additionally, PH04 is Formaldehyde, and PH03 is not.
| DEVICE_TYPE_PURE_HOT_COOL_LINK: "Pure Hot+Cool Link", | ||
| DEVICE_TYPE_PURE_HUMIDIFY_COOL: "Pure Humidify+Cool", | ||
| DEVICE_TYPE_PURIFIER_HUMIDIFY_COOL_FORMALDEHYDE: "Purifier Humidify+Cool Formaldehyde", | ||
| DEVICE_TYPE_PURE_COOL: "Pure Cool (TP04/TP07)", |
There was a problem hiding this comment.
I believe this is incorrect. DEVICE_TYPE_PURE_COOL is the code "475", which is the model TP04.
TP07 is a "Purifier Cool" model, and has a different code (Likely 475 with a letter suffix, similar to how Pure Hot+Cool HP04 is "527" and Purifier Hot+Cool HP07 is "527K")
|
I am going to be abandoning this change. The constants don't match up with the actual list of Dyson products, and it is getting too hard to desirer what is what. |
2 participants
I found the naming very confusing when trying to pick the correct device, and decided to provide a pull request to match the names against the Dyson names and models to help future people who consume the library.