Fix: replace segmentModifier default arg with EmptyModifier overload#3
Open
shima11 wants to merge 1 commit into
Open
Fix: replace segmentModifier default arg with EmptyModifier overload#3shima11 wants to merge 1 commit into
shima11 wants to merge 1 commit into
Conversation
Using a default expression for generic type inference will become an error in a future Swift language mode. Add a constrained extension (where Modifier == EmptyModifier) with a convenience init instead, preserving the existing call sites that omit segmentModifier. Closes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
segmentModifier: Modifier = EmptyModifier()のデフォルト引数を削除し、where Modifier == EmptyModifierの convenience init に置き換えsegmentModifierを省略している箇所）は引き続き動作するswift buildで警告が消えたことを確認済みTest plan
swift buildが警告なしで通ることsegmentModifierを省略した既存の呼び出しがコンパイルエラーにならないことsegmentModifierにEmptyModifier以外を渡す呼び出しがコンパイルエラーにならないことCloses #2