Add support to add labels and annotations to build pod#1150
Add support to add labels and annotations to build pod#1150wanjunlei wants to merge 1 commit intoshipwright-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
5a3dd36 to
7831ade
Compare
Signed-off-by: wanjunlei <wanjunlei@kubesphere.io>
|
Thanks for engaging @wanjunlei In Shipwright, we often distinguish two personas: build strategy authors and build users. Build strategy authors define which steps need to be performed to reach a certain behavior. Pod annotations often cause a behavior, for example Because of this, we already have the capability to propage annotations from build strategies to taskruns, but not from builds or buildruns. See Propagating annotations from the build strategy to the pod. Similarly, there is effort in progress related to labels, and here to also include a propagation for Build users. We invite you to join our community meeting, https://github.com/shipwright-io/community#how-can-i-get-involved. In general, every API change requires an enhancement proposal, which we call SHIPs. /hold |
Signed-off-by: wanjunlei wanjunlei@kubesphere.io
Changes
This pr adds two fields
labelsandannotationsto theBuildandBuildRunCRD, the controller will add the labels and annotations to thetaskrun, and eventually be added to the build pod.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes