Skip to content

feat: add missing instructions for manual installation#220

Merged
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
idiap:feat/add-missing-instruction-for-direct-installation
May 4, 2026
Merged

feat: add missing instructions for manual installation#220
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
idiap:feat/add-missing-instruction-for-direct-installation

Conversation

@sgaist
Copy link
Copy Markdown
Contributor

@sgaist sgaist commented May 3, 2026

Changes

This PR adds missing instructions for the manual installation in the getting started guide.
The manifest is not enough, there's also the need for:

  • Webhook secret creation
  • Storage migration

It's documentated in the build's repository README.

Related Issue

Fixes #221

Type of PR

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Missing instruction for the manual manifest deployment of build have been added

The manifest is not enough, there's also the need for:

- Webhook secret creation
- Storage migration

It's documentated in the build's repository README.

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@pull-request-size pull-request-size Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2026
@openshift-ci openshift-ci Bot added the kind/bug Categorizes issue or PR as related to a bug. label May 3, 2026
@openshift-ci openshift-ci Bot requested review from HeavyWombat and rxinui May 3, 2026 19:44
Copy link
Copy Markdown
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 5bd1321 into shipwright-io:main May 4, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Issues May 4, 2026
@sgaist sgaist deleted the feat/add-missing-instruction-for-direct-installation branch May 4, 2026 09:04
@kastl-ars
Copy link
Copy Markdown

$ curl --silent --location https://raw.githubusercontent.com/shipwright-io/build/latest/hack/setup-webhook-cert.sh | bash

This file does not exist...

$ curl https://raw.githubusercontent.com/shipwright-io/build/latest/hack/setup-webhook-cert.sh
404: Not Found$

@sgaist
Copy link
Copy Markdown
Contributor Author

sgaist commented May 6, 2026

$ curl --silent --location https://raw.githubusercontent.com/shipwright-io/build/latest/hack/setup-webhook-cert.sh | bash

This file does not exist...

$ curl https://raw.githubusercontent.com/shipwright-io/build/latest/hack/setup-webhook-cert.sh
404: Not Found$

Good catch ! Sorry for the mishap, fix is available in #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Documentation does not mention secret required for installation via manifest

4 participants