fix: background color in dark mode on password-field (#1175)#1177
Merged
Fabian Hüske (fabianhueske) merged 1 commit intoJun 24, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Arnold Stoba (arnoldstoba)
approved these changes
Jun 24, 2026
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/create-meteor-extension
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
318f621 to
0e40502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the
mt-password-fieldshowing the parent surface behind the password visibility-toggle button in dark mode. The field now renders a consistent--color-background-primary-defaultsurface across both the input and the toggle button.Closes #1175
Why?
In dark mode the toggle button's box was transparent, so the darker parent surface bled through next to the input, breaking the visual continuity of the field. The field surface is painted only by the
<input>(background: var(--color-background-primary-default)), while.mt-block-field__blockhas no background of its own and the toggle button only sets a background on hover/focus. The mismatch is invisible in light mode (everything is near-white) but obvious in dark mode, where--color-background-primary-default(#1e1e24) differs from the surrounding parent surfaces (for example#101013).The disabled state was already patched at the block level in this component, but the default state was missed.
How?
Scoped to the password field, the field block now gets
--color-background-primary-defaultas its default background (mirroring the existing disabled override), so the transparent toggle-button area inherits the field surface instead of the parent. An explicit--color-background-critical-defaultoverride is added for the error state so the cascade cannot regress it.A patch changeset is included for
@shopware-ag/meteor-component-library.Testing?
Screenshots (optional)
Before / after in dark mode (toggle button area):
Anything Else?
The underlying cause sits in the shared
mt-base-field, where.mt-block-field__blockhas no background of its own and relies on the<input>to paint the surface. This fix is scoped to the password field to stay low-risk, but a follow-up could give the block a default background in the base component so any field embedding extra controls in the element slot gets consistent theming for free.