Fix for error when getting sgtk alembic nodes.#9
Open
reformstudios wants to merge 1 commit intoshotgunsoftware:masterfrom
Open
Fix for error when getting sgtk alembic nodes.#9reformstudios wants to merge 1 commit intoshotgunsoftware:masterfrom
reformstudios wants to merge 1 commit intoshotgunsoftware:masterfrom
Conversation
The following methods are failing :- hou.nodeType(hou.ropNodeTypeCategory(), tk_node_type).instances() hou.nodeType(hou.sopNodeTypeCategory(), tk_node_type).instances() This is because if there are no nodes of that type, the first part of the line returns None, and raises an error as it has no "instances()" method. The nodes need to be gathered first, and if there are are any, THEN get their instances.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| tk_alembic_nodes.extend( | ||
| rop_nodes.instances() | ||
| ) | ||
|
|
| sop_nodes = hou.nodeType(hou.sopNodeTypeCategory(), tk_node_type) | ||
| rop_nodes = hou.nodeType(hou.ropNodeTypeCategory(), tk_node_type) | ||
| if sop_nodes: | ||
| tk_alembic_nodes.extend( |
| sop_nodes = hou.nodeType(hou.sopNodeTypeCategory(), tk_node_type) | ||
| rop_nodes = hou.nodeType(hou.ropNodeTypeCategory(), tk_node_type) | ||
| if sop_nodes: | ||
| tk_alembic_nodes.extend( |
|
|
||
| sop_nodes = hou.nodeType(hou.sopNodeTypeCategory(), cls.HOU_SOP_ALEMBIC_TYPE) | ||
| rop_nodes = hou.nodeType(hou.ropNodeTypeCategory(), cls.HOU_ROP_ALEMBIC_TYPE) | ||
|
|
| hou.ropNodeTypeCategory(), cls.HOU_ROP_ALEMBIC_TYPE | ||
| ).instances() | ||
| ) | ||
|
|
There was a problem hiding this comment.
Black would make changes.
blank line contains whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following methods are failing :-
hou.nodeType(hou.ropNodeTypeCategory(), tk_node_type).instances()
hou.nodeType(hou.sopNodeTypeCategory(), tk_node_type).instances()
This is because if there are no nodes of that type, the first part of the line returns None, and raises an error as it has no "instances()" method.
The nodes need to be gathered first, and if there are are any, THEN get their instances.