Resolve compile issue with recent Eigen version#1
Merged
shrddr merged 2 commits intoshrddr:masterfrom Jul 12, 2021
danuo:master
Merged
Resolve compile issue with recent Eigen version#1shrddr merged 2 commits intoshrddr:masterfrom danuo:master
shrddr merged 2 commits intoshrddr:masterfrom
danuo:master
Conversation
This fix is necessary to compile g2opy on all platforms, using recent version of Eigen see issue at uoip#16 original commit message: Quaterniond::w returns const double & instead of double to work with Eigen CoeffReturnType
shaoxh
approved these changes
Feb 13, 2021
| .def("x", (const double& (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::x) | ||
| .def("y", (const double& (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::y) | ||
| .def("z", (const double& (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::z) | ||
| .def("w", (const double& (Eigen::Quaterniond::*) () const) &Eigen::Quaterniond::w) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is necessary to compile g2opy on all platforms,
using recent version of Eigen
see issue at uoip#16
original commit message:
Quaterniond::w returns const double & instead of double to work with
Eigen CoeffReturnType