Create a basic simple Rock Paper Scissor game#8
Open
thsh-odoo wants to merge 2 commits intoshsa-odoo:mainfrom
Open
Create a basic simple Rock Paper Scissor game#8thsh-odoo wants to merge 2 commits intoshsa-odoo:mainfrom
thsh-odoo wants to merge 2 commits intoshsa-odoo:mainfrom
Conversation
shsa-odoo
reviewed
Feb 10, 2023
task1.js
Outdated
| @@ -0,0 +1,69 @@ | |||
| const choices=['Rock','Paper','Scissor']; | |||
Owner
There was a problem hiding this comment.
Give proper spacing while assignment:
const choices = ['Rock','Paper','Scissor'];
update it for all cases in the code.
shsa-odoo
reviewed
Feb 10, 2023
task1.js
Outdated
Comment on lines
3
to
69
| function rock() | ||
| { | ||
| let computer_choice=Math.floor(Math.random() * choices.length); | ||
| console.log(choices[computer_choice]) | ||
|
|
||
| if(choices[computer_choice]=='Rock') | ||
| { | ||
| // console.log("helllllllo") | ||
| document.getElementById("status").textContent="Draw"; | ||
| } | ||
| else if (choices[computer_choice]=='Paper') | ||
| { | ||
| document.getElementById("status").textContent="Computer Wins"; | ||
| computer_score+=1; | ||
| document.getElementById("computer_score").textContent=computer_score; | ||
| console.log(computer_score) | ||
| } | ||
| else if(choices[computer_choice]=='Scissor') | ||
| { | ||
| document.getElementById("status").textContent="You Win"; | ||
| user_scores+=1; | ||
| document.getElementById("user_scores").textContent=user_scores; | ||
| console.log(user_scores) | ||
| } | ||
| } | ||
| function paper() | ||
| { | ||
| let computer_choice=Math.floor(Math.random() * choices.length); | ||
| console.log(choices[computer_choice]) | ||
| if(choices[computer_choice]=='Paper') | ||
| { | ||
| document.getElementById("status").textContent="Draw"; | ||
| } | ||
| else if (choices[computer_choice]=='Scissor') | ||
| { | ||
| document.getElementById("status").textContent="Computer Wins"; | ||
| computer_score+=1; | ||
| document.getElementById("computer_score").textContent=computer_score; | ||
| } | ||
| else if(choices[computer_choice]=='Rock') | ||
| { | ||
| document.getElementById("status").textContent="You Win"; | ||
| user_scores+=1; | ||
| document.getElementById("user_scores").textContent=user_scores; | ||
| } | ||
| } | ||
| function scissor() | ||
| { | ||
| let computer_choice=Math.floor(Math.random() * choices.length); | ||
| console.log(choices[computer_choice]) | ||
| if(choices[computer_choice]=='Scissor') | ||
| { | ||
| document.getElementById("status").textContent="Draw"; | ||
| } | ||
| else if (choices[computer_choice]=='Rock') | ||
| { | ||
| document.getElementById("status").textContent="Computer Wins"; | ||
| computer_score+=1; | ||
| document.getElementById("computer_score").textContent=computer_score; | ||
| } | ||
| else if(choices[computer_choice]=='Paper') | ||
| { | ||
| document.getElementById("status").textContent="You Win"; | ||
| user_scores+=1; | ||
| document.getElementById("user_scores").textContent=user_scores; | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Making separate function call for separate event is good.
But optimize the code:
- using ternary operator. as user can win in three cases only :
you_win = ( (you === "rock") && (opponent === "scissor") ||
(you === "paper") && (opponent === "rock") ||
(you === "scissor") && (opponent === "rock") ) // returns true for your win cases only.
.
.
so (you === opponent) ? "draw message" : you_win ? call a method for updating score and message for user : call method for updating score and message fro computer;
3.(note* for this case only.) use concept of querySelectorAll("button"), and foreach click call a method that update the state of your game.
4. declare it a const computer_choice=Math.floor(Math.random() * choices.length); and on every time your method calls while button click , you will get a random method.
Author
There was a problem hiding this comment.
Okay sir
I have optimize my code in today's RPS game using owl I will do it same in this code without owl
shsa-odoo
reviewed
Feb 10, 2023
task1.js
Outdated
|
|
||
| if(choices[computer_choice]=='Rock') | ||
| { | ||
| // console.log("helllllllo") |
Owner
There was a problem hiding this comment.
discard the unwanted/ commeted out code while you push the code. make it a habit of checking the code you push.
…to perform the task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed the task of creating a small basic game of rock paper scissor