Upgrade go-ethereum to match shlib's version#422
Open
konradkonrad wants to merge 1 commit intomainfrom
Open
Conversation
`shlib/v0.1.14` uses `go-ethereum@v1.13.4`.
Contributor
Author
|
Here's the node output from one of the play tasks ( |
Contributor
|
We need NomicFoundation/hardhat#4438 to be released to support this newer version. |
Contributor
Author
|
It seems NomicFoundation/edr#444 did fix this incompatibility. |
konradkonrad
added a commit
that referenced
this pull request
Jul 2, 2024
Since upgrading to `go-ethereum@v1.13.4` the `play` tests were not compatible anymore (see #422). On hardhats side, the problem was addressed in NomicFoundation/edr#444.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shlib/v0.1.14usesgo-ethereum@v1.13.4.This PR has the change in isolation, so we can debug any incompatibilities as a prerequisite for merging #416
I found the following potential breaking change:
geth --devnow simulates a PoS-based chain (cmd/geth: implement dev mode for post-merge ethereum/go-ethereum#27327) v1.12.1