Open
Conversation
ylembachar
reviewed
Apr 3, 2025
Collaborator
There was a problem hiding this comment.
Looks good to me if you could additionally add the following:
- a docker compose service that runs this test specifically
- README instructions to run the test
- Instead of printing the statistics, could you please log them to an external file, such as the blame file in the gnosis continuous test?
- The test stops if there is an error from the API (such as the keyper not being reachable) and this is not reflected in the results, if you can add this fix as well. We should see the number of successful attempts, the number of failures and the errors corresponding to these failures.
- Add the possibility to run the test for different configs in parallel (i.e for both chiado and mainnet in parallel).
tests/decryptionmonitor.go
Outdated
| waitDuration := time.Until(decryptTime.Add(2 * time.Second)) | ||
|
|
||
| time.Sleep(waitDuration) | ||
| seconds, err := strconv.Atoi(os.Getenv("DEC_KEY_WAIT_INTERVAL")) |
Collaborator
There was a problem hiding this comment.
Could you please update this to be in ms? Thank you!
Contributor
There was a problem hiding this comment.
This is in accordance with gnosis chain timestamps, so not sure what is the reason for us to change it to ms.
Contributor
|
@ylembachar added the additional functionalities mentioned above. For |
blockchainluffy
requested review from
konradkonrad and
ylembachar
and removed request for
ylembachar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20