Fix Missing PQC KEM Verbose Tests#53
Conversation
- Because this order is better for verbose tests.
|
I'm not sure I understand the reasoning behind the automatic generation of test cases by writing to files. A better way to accomplish this is to leverage test templates. The same technique must be applied to simplify how existing tests are written. For example, there are tests like |
| tags.append(test_type) | ||
| tags.append(hybrid_type) | ||
| tags.extend(["hybrid", "hybrid-kem"]) |
There was a problem hiding this comment.
A somewhat peculiar choice to use extend here, and append there, no?
My Idea was to have the test cases static and generate the test cases with a script, so that they can be easily changed, if new combinations or algorithms are added. And for the test case itself are template test cases added. And additionally we have tags and can ignore algorithms or combinations with the tags and do not use a config variable for that. To explain it a little bit more, currently I write the test cases into a text file, so that I manually have to copy them into the RF files, to be static and not created during run time. |
|
But this could also be done via |
|
@ralienpp Did you mean something like this: https://github.com/Guiliano99/cmp-test-suite-update-code/blob/UpdateVerboseTests/tests_pq_and_hybrid/kem_alg.robot |
Fixed missing verbose test for the PQC KEM algorithms, which were completely missing.
Description
kem_alg.robotfile, generated withscripts/generate_alg_test_cases.py.kem_alg.robotkeywords sections to allow easier modification of test cases.kem_alg.robotfile.TODO
Motivation and Context
How Has This Been Tested?
MockCA