docs(buttons): update buttons examples #1263
Conversation
|
Documentation. Coverage Reports: |
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
3 times, most recently
from
1ad8334 to
e0e8f09
Compare
| </div> | ||
|
|
||
| <div class="btn-group" role="group" aria-label="Tertiary group"> | ||
| <button type="button" class="btn btn-icon btn-ghost" aria-label="Edit"> |
There was a problem hiding this comment.
Hi @panch1739, quick question for the button group: in the case where it contains icons only, can it also be presented using the ghost button variant?
There was a problem hiding this comment.
@dauriamarco this is so funny, today i was using the button group and i had the same thought ahahah. Yes, we should totally show the ghost version also. Im sure this and the tertiary variant will be te most common
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
2 times, most recently
from
13efd16 to
d74f0a6
Compare
dauriamarco
requested review from
a team,
dr-itz and
spliffone
as code owners
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
from
d74f0a6 to
7eea157
Compare
dauriamarco
changed the title
panch1739
left a comment
panch1739
left a comment
There was a problem hiding this comment.
@dauriamarco It looks good for me, but i have one note...the icons inside the buttons should not be the filled version. In our design system, filled version of icons are used for emphasis or to represent that the icon is active.
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
from
7eea157 to
9eb91b6
Compare
|
|
panch1739
left a comment
panch1739
left a comment
There was a problem hiding this comment.
@dauriamarco I found only one thing:
Button group, icon-only version: Button width should be also 40px instead of 32px
All the rest looks good! Thank youuu
Updates and improves all buttons examples including
buttoncategoriesaccording to the newbtn-iconspecs.