-
Notifications
You must be signed in to change notification settings - Fork 13
refactor(launchpad): add open and close animation #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dauriamarco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the application's launchpad by introducing elegant open and close animations. Beyond the visual flair, it includes a comprehensive refactoring of the launchpad's internal components, improving its structure, responsiveness, and accessibility. Key text labels have been updated for better user understanding, and the example component now offers more robust demonstration capabilities, making the launchpad more intuitive and versatile. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds open and close animations to the launchpad and refactors its components for an improved design. The changes are well-implemented, especially the use of modern CSS for animations and the significant enhancements to the example page.
I have a couple of suggestions. One is a critical fix for a test in playwright/e2e/element-examples/si-launchpad.spec.ts where the test logic contradicts its purpose, and I've added a reference to a rule regarding test resilience. The other is a suggestion to improve the maintainability of the example component in src/app/examples/si-application-header/si-launchpad.ts by refactoring how app categories are determined. Overall, great work on this feature.
|
Documentation. Coverage Reports: |
projects/element-ng/application-header/launchpad/si-launchpad-app.component.html
Show resolved
Hide resolved
ba9a640 to
e0a6e62
Compare
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
e0a6e62 to
6378c30
Compare
projects/element-ng/application-header/launchpad/si-launchpad-factory.component.scss
Outdated
Show resolved
Hide resolved
6378c30 to
e3592b5
Compare
e3592b5 to
a13d62f
Compare
| transform: translateY(-120px); | ||
| } | ||
|
|
||
| &.expand-leave { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename the class to something like launchpad-leave the expand +. leave confuses me while reading it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👍
a13d62f to
20590ad
Compare
projects/element-ng/application-header/launchpad/si-launchpad-factory.component.scss
Outdated
Show resolved
Hide resolved
projects/element-ng/application-header/si-application-header.component.html
Outdated
Show resolved
Hide resolved
20590ad to
d55029c
Compare
spike-rabbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seesm like you have some redundant transition definition. Otherwise 👍
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
projects/element-ng/application-header/si-application-header.component.scss
Outdated
Show resolved
Hide resolved
d55029c to
288571f
Compare
288571f to
0692d3a
Compare
Related to #1236. Adds an open/close animation for the launchpad panel.