Skip to content

fix: adjust angular versions IX-3873#182

Open
alexkaduk wants to merge 2 commits intomainfrom
feature/IX-3873
Open

fix: adjust angular versions IX-3873#182
alexkaduk wants to merge 2 commits intomainfrom
feature/IX-3873

Conversation

@alexkaduk
Copy link
Collaborator

💡 What is the current behavior?

The Angular installation documentation shows outdated peer dependency versions (Angular 18.2.13+) when Angular 20+ is actually required for iX v4.x.

🆕 What is the new behavior?

  • Updated Angular peer dependency requirements from >=18.2.13 to >=20
  • Added link to GitHub package.json as source of truth

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for industrial-experience ready!

Name Link
🔨 Latest commit a7fb37c
🔍 Latest deploy log https://app.netlify.com/projects/industrial-experience/deploys/6988c544bd81bb0009d72195
😎 Deploy Preview https://deploy-preview-182--industrial-experience.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @alexkaduk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the Angular installation documentation displayed outdated peer dependency versions, potentially leading to incorrect installations. The changes update the required Angular versions to 20+ and provide a direct link to the package.json for accurate version information, ensuring users can correctly set up their iX v4.x projects.

Highlights

  • Documentation Update: The Angular peer dependency requirements in the installation documentation have been updated from >=18.2.13 to >=20 to reflect the actual versions needed for iX v4.x.
  • Source of Truth Link: A direct link to the GitHub package.json file has been added to the documentation, serving as the definitive source for peer dependency versions.
Changelog
  • docs/home/installation/angular.md
    • Updated the listed Angular peer dependency versions from >=18.2.13 to >=20.
    • Added a link to the package.json file on GitHub to provide a dynamic source of truth for peer dependency requirements.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Angular peer dependency versions in the documentation and adds a link to the package.json for future reference, which is a great improvement. I have one minor suggestion to align the wording with the style guide's preference for active voice.

### Peer dependencies

Both `@angular/core` and `@angular/forms` are peer dependencies which means they must be installed before iX.
Both `@angular/core` and `@angular/forms` are peer dependencies which must be installed before iX.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To better align with the style guide, consider rephrasing this sentence to use active voice. The guide recommends using active voice and addressing the reader with 'you'.

Suggested change
Both `@angular/core` and `@angular/forms` are peer dependencies which must be installed before iX.
Both `@angular/core` and `@angular/forms` are peer dependencies that you must install before iX.
References
  1. The style guide recommends using active voice instead of passive voice (line 62) and using 'you' to talk to readers (line 24). (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant