Conversation
…MIME types isntead of octet-stream
solidiquis
requested changes
Mar 24, 2026
…am for missing extensions
solidiquis
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed:
Instead of raising an error when a file upload didn't have a supported MIME type in mimetypes (built-in python library), we will fallback to a generic binary data MIME type:
application/x-{extension}. The backend simply stores the files to S3 and serves them back for download (presigned S3 url) with no special processing based on MIME/content type (remote_file_service.go).Verification
Unit tests to verify the
upload_attachmentfunction will return a mime type ofapplication/x-{extension}for file types that are not currently supported in mimetypes.Tested file attachment uploads on a local script with file types not supported by mimetypes and verified the data was intact.