fix(idp): stamp current signing key's kid on refreshed tokens#171
Open
paulojmdias wants to merge 1 commit into
Open
fix(idp): stamp current signing key's kid on refreshed tokens#171paulojmdias wants to merge 1 commit into
paulojmdias wants to merge 1 commit into
Conversation
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fosite restores the persisted session (including JWTHeader.kid) on refresh_token grants. After the proxy's signing key is rotated (e.g., via cert-manager), the emitted JWT was signed with the new key but advertised the old kid, causing downstream JWKS-based verifiers to fail with "no keys found" until the user performed a full re-auth.
Override the kid header with the current key's ID before minting the access response.
Adds
TestRefreshTokenUsesCurrentSigningKidwhich simulates a pod restart with a rotated key and asserts the refreshed token advertises the new kid.Type of Change
Assisted-By: Claude Opus 4.7