fix(auth): return 400 and hide internal errors on auth callback failures#172
Open
paulojmdias wants to merge 1 commit into
Open
fix(auth): return 400 and hide internal errors on auth callback failures#172paulojmdias wants to merge 1 commit into
paulojmdias wants to merge 1 commit into
Conversation
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auth callback endpoints (
/.auth/{oidc,github,google}/callback) returned HTTP 500 and leaked the app name and internal error text (e.g."OAuth state is missing") to unauthenticated callers.This patch returns the correct status code (400 for client-side OAuth state errors, 500 only for genuine server faults), renders a generic
"Authentication failed"page, and removes the app name from the<title>. Internal errors are preserved in server-sidezaplogs, so operator debuggability is unchanged. CSRF/state validation is unaffected.Type of Change