Skip to content

fix(idp): apply RFC 7591 §2 defaults to DCR registration response #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmatte wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(idp): apply RFC 7591 §2 defaults to DCR registration response #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/idp/idp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,20 @@ func (a *IDPRouter) handleRegister(c *gin.Context) {
return
}

// RFC 7591 §2: apply server-side defaults for omitted optional fields, so
// the persisted client and the registration response are spec-compliant.
// Strict clients (e.g. LM Studio's Zod schema) reject null/empty values
// here; any caller-supplied values are preserved verbatim.
if len(req.GrantTypes) == 0 {
req.GrantTypes = []string{"authorization_code"}
}
if len(req.ResponseTypes) == 0 {
req.ResponseTypes = []string{"code"}
}
if req.TokenEndpointAuthMethod == "" {
req.TokenEndpointAuthMethod = "client_secret_basic"
}

clientID, err := utils.GenerateClientID()
if err != nil {
a.logger.Error("Failed to generate client ID", zap.Error(err))
Expand Down