Reduce the docker image size using FROM scratch#176
Open
LucaDario wants to merge 2 commits into
Open
Conversation
LucaDario
requested review from
Copilot and
hrntknr
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the runtime container image to a minimal scratch base to reduce image size and remove unused OS packages.
Changes:
- Switch runtime stage from
debian:bookworm-slimtoscratch. - Remove
apt-getinstalls for certificates/tools/runtimes and instead copy the CA bundle from the builder stage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+17
| FROM scratch | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| ca-certificates curl python3 python3-pip nodejs npm \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt |
| go build -trimpath -ldflags "-w -s" -o /app/bin/main . | ||
|
|
||
| FROM debian:bookworm-slim | ||
| FROM scratch |
Comment on lines
19
to
20
| COPY --from=builder /app/bin/main /usr/local/bin/mcp-auth-proxy | ||
| ENV DATA_PATH=/data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the containerization strategy by switching the final Docker image stage to FROM scratch, significantly reducing image size and attack surface while preserving runtime behavior.
Type of Change