perf: add FastBPETrainer using word-frequency counting#13
Closed
AmitMY wants to merge 1 commit into
Closed
Conversation
2 tasks
AmitMY
force-pushed
the
perf/incremental-counting
branch
11 times, most recently
from
f364502 to
5c951a9
Compare
- FastBPETrainer flattens words into byte tuples and counts word frequencies, avoiding repeated graph traversal - Pair counting operates on word-freq dict instead of full corpus - Produces identical merges to graph-based BPE (tested) - Significantly faster on repeated text patterns Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
force-pushed
the
perf/incremental-counting
branch
from
5c951a9 to
2aa3dcc
Compare
Contributor
Author
|
Closing — if we want a flat word-frequency BPE implementation, we'd just use HuggingFace tokenizers directly. |
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FastBPETrainerthat flattens words into byte tuples and counts word frequenciesStacked on #12.
What improved
Test plan
ruff check .passes🤖 Generated with Claude Code