Skip to content

Fix for #2688 New Years Polycom NOTIFY Cseq Rollover #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junction1153b wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −7
Open

Fix for #2688 New Years Polycom NOTIFY Cseq Rollover #2959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/mod/endpoints/mod_sofia/sofia_presence.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2137,18 +2137,22 @@ static switch_uint31_t check_presence_epoch(void)
uint32_t sofia_presence_get_cseq(sofia_profile_t *profile)
{
switch_uint31_t callsequence;
int diff = 0;

switch_mutex_lock(profile->ireg_mutex);

callsequence = check_presence_epoch();

if (profile->last_cseq.value) {
diff = (int)callsequence.value - (int)profile->last_cseq.value;
if (diff <= 0 && diff > -100000) {
callsequence.value = ++profile->last_cseq.value;
}
}
/* Enforce strictly monotonic CSeq for NOTIFY to avoid New Year rollbacks
that some phones (e.g., Polycom) reject with 500. */
if (profile->last_cseq.value && callsequence.value <= profile->last_cseq.value) {
callsequence.value = profile->last_cseq.value + 1;
}

/* Keep within 31 bits and non-zero, matching switch_uint31_t semantics. */
callsequence.value &= 0x7fffffff;
if (callsequence.value == 0) {
callsequence.value = 1;
}

profile->last_cseq = callsequence;

Expand Down