-
-
Notifications
You must be signed in to change notification settings - Fork 38
#508 Allow seeking audio to next/previous heading #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benpaj-cps
wants to merge
12
commits into
sillsdev:main
Choose a base branch
from
benpaj-cps:fix/audio-seek-headings/GH-508
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c55f61c
Begin implementing heading seek
benpaj-cps f540297
Fix audio seek to heading for all known cases
benpaj-cps 1bc2214
Fix lint errors and edge cases
benpaj-cps 88b8611
Fix formatting, adjust seek threshold
benpaj-cps cafcc4a
Fix seek to zero not updating highlights
benpaj-cps 765087f
Fix audio heading time retrieval for deeply nested HTML
benpaj-cps 75d9e6d
Fix forward skip not advancing more than one heading while paused
benpaj-cps aeb82b8
Fix audio highlight showing in chapter with timing before audio has b…
benpaj-cps e818cae
Remove added debug logging
benpaj-cps 693fbf3
Run formatter
benpaj-cps f69ee81
Handle chapters without headings properly
benpaj-cps ce7e2b4
Add comments, error warn for seek to heading
benpaj-cps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.